Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(natives/gamebuild): update natives from the 2189 gamebuild #958

Closed
wants to merge 1 commit into from
Closed

feat(natives/gamebuild): update natives from the 2189 gamebuild #958

wants to merge 1 commit into from

Conversation

spacevx
Copy link
Contributor

@spacevx spacevx commented Dec 24, 2023 •
edited
Loading

Update natives from the 2189 gamebuild with names and descriptions, should be good for review @4mmonium

@spacevx spacevx changed the title feat(natives/2189): update natives from the 2189 gamebuild feat(natives/gamebuild): update natives from the 2189 gamebuild Dec 24, 2023
4mmonium
4mmonium suggested changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey so far this looks almost OK, left you some comments regarding cs_type usage. Thanks!

OBJECT/SetPropTintIndex.md Outdated Show resolved Hide resolved
VEHICLE/SetIgnorePlanesSmallPitchChange.md Outdated Show resolved Hide resolved
@spacevx spacevx requested a review from 4mmonium December 26, 2023 09:07
@spacevx
Copy link
Contributor Author

spacevx commented Dec 26, 2023

Hey @4mmonium happy holidays to you 🎉and should be good, if you could check my issue #961 would be awesome!

4mmonium
4mmonium suggested changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more changes needed, guess I may have overlooked that, thanks!

PATHFIND/SetAllowStreamHeistIslandNodes.md Outdated Show resolved Hide resolved
PATHFIND/SetAllowStreamHeistIslandNodes.md Outdated Show resolved Hide resolved
@spacevx spacevx requested a review from 4mmonium December 27, 2023 18:49
@spacevx
Copy link
Contributor Author

spacevx commented Feb 5, 2024

Description of SET_IGNORE_PLANES_SMALL_PITCH_CHANGE and SET_ALLOW_STREAM_HEIST_ISLAND_NODES have been revised to clarify their purpose

@spacevx spacevx closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4mmonium 4mmonium Awaiting requested review from 4mmonium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spacevx @4mmonium