Support rails 8.0.0 #260
Merged
Support rails 8.0.0 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpaca-tc
commented
Sep 30, 2024
| @@ -21,7 +21,7 @@ def update_all(updates) | |||
|
|
|||
| stmt = Arel::UpdateManager.new | |||
| stmt.table(table) | |||
| stmt.set Arel.sql(@klass.send(:sanitize_sql_for_assignment, updates)) | |||
| stmt.set Arel.sql(klass.send(:sanitize_sql_for_assignment, updates)) | |||
There was a problem hiding this comment.
related: rails/rails#51932
alpaca-tc
force-pushed
the
support-8-0-0
branch
from
9a78cf8
to
d4a1eef
Compare
|
@gurkanindibay Rails 8.0 was released yesterday! 🎉 Check it out: https://rubyonrails.org/2024/11/7/rails-8-no-paas-required |
alpaca-tc
force-pushed
the
support-8-0-0
branch
from
d4a1eef
to
abdff2f
Compare
Thank you @alpaca-tc |
|
@alpaca-tc can you check the 'static-checks' task output? It's failing |
```
lib/activerecord-multi-tenant/model_extensions.rb:69:37: C: [Corrected] Style/KeywordArgumentsMerging: Provide additional arguments directly rather than using merge.
belongs_to tenant_name, **options.slice(:class_name, :inverse_of, :optional) ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
@gurkanindibay Fixed 💛 The latest version of rubocop seems to detect it. |
gurkanindibay
approved these changes
Nov 11, 2024
|
Thanks @alpaca-tc for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not yet examined it in detail, but I have fixed what is obviously broken.
The
ActiveRecord::VERSION::MAJOR >= 7 && ActiveRecord::VERSION::MINOR >= 2branch is clearly wrong and will not work as expected with 8.0, so please merge this PR 🙏