PG17 compatibility: Fix Test Failure in pg13_propagate_statistics #7728
+48
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7728 +/- ##
===============================================
Coverage ? 89.64%
===============================================
Files ? 274
Lines ? 59582
Branches ? 7436
===============================================
Hits ? 53412
Misses ? 4038
Partials ? 2132 |
onurctirtir
reviewed
Nov 11, 2024
naisila
changed the title
naisila
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Nice fix, thanks @m3hm3t and @onurctirtir
Always appreciate a fix that avoids a new output file :)
Let's merge directly to release-13.0 by including only the commits relevant to this PR
and then after merging let's rebase naisila/pg17_support branch to release-13.0 branch
This was referenced Nov 12, 2024
m3hm3t
force-pushed
the
pg13_propagate_stats
branch
from
4604ae1
to
f892a78
Compare
update update update . update update update .
m3hm3t
force-pushed
the
pg13_propagate_stats
branch
from
f892a78
to
65a5730
Compare
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed stxstattarget in pg_statistic_ext to use nullable representation, removing explicit -1 for default statistics target in PostgreSQL 17.
postgres/postgres@012460e
SELECT stxstattarget, stxrelid::regclass FROM pg_statistic_ext WHERE stxnamespace IN ( SELECT oid FROM pg_namespace WHERE nspname IN ('statistics''TestTarget') ) AND stxname SIMILAR TO '%\_\d+' ORDER BY stxstattarget, stxrelid::regclass ASC; stxstattarget | stxrelid ---------------+----------------------------------- - -1 | "statistics'TestTarget".t1_980000 - -1 | "statistics'TestTarget".t1_980002 ... + | "statistics'TestTarget".t1_980000 + | "statistics'TestTarget".t1_980002 ...