PG17 compatibility: Fix Test Failure in alter_index #7729
Closed
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7729 +/- ##
===============================================
Coverage ? 89.64%
===============================================
Files ? 274
Lines ? 59582
Branches ? 7436
===============================================
Hits ? 53415
Misses ? 4035
Partials ? 2132 |
naisila
changed the title
naisila
approved these changes
Nov 12, 2024
39 tasks
m3hm3t
force-pushed
the
m3hm3t/alter_index
branch
from
f56794f
to
6f81c91
Compare
update . update . update Revert "update" This reverts commit 630cff9. update update .
m3hm3t
force-pushed
the
m3hm3t/alter_index
branch
from
6f81c91
to
e0da343
Compare
naisila
reviewed
Nov 14, 2024
| SELECT c.relname, a.attstattarget | ||
| -- pg17 Changed `attstattarget` in `pg_attribute` to use `NullableDatum`, allowing null representation for default statistics target in PostgreSQL 17. | ||
| -- https://github.com/postgres/postgres/commit/6a004f1be87d34cfe51acf2fe2552d2b08a79273 | ||
| SELECT c.relname, |
There was a problem hiding this comment.
style fix
Suggested change
| SELECT c.relname, | |
| SELECT c.relname, |
| FROM pg_attribute a | ||
| JOIN pg_class c ON a.attrelid = c.oid AND c.relname LIKE 'test\_idx%' | ||
| ORDER BY c.relname, a.attnum; | ||
|
|
||
| \c - - - :worker_1_port | ||
| SELECT c.relname, a.attstattarget | ||
| SELECT c.relname, |
There was a problem hiding this comment.
style fix
Suggested change
| SELECT c.relname, | |
| SELECT c.relname, |
naisila
reviewed
Nov 14, 2024
| @@ -80,11 +80,11 @@ typedef enum DistOpsOperationType | |||
| */ | |||
| typedef struct DistributeObjectOps | |||
| { | |||
| char * (*deparse)(Node *); | |||
| char *(*deparse)(Node *); | |||
There was a problem hiding this comment.
Can you open a separate PR for these style fixes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
attstattargetinpg_attributeto useNullableDatum, allowing null representation for default statistics target in PostgreSQL 17.postgres/postgres@6a004f1