Update Data Tracker JS and CSS from production app #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mddilley
commented
Jun 23, 2022
Comment on lines
+916
to
+927
| //// Update link text to cabinet details page from signal detals | ||
| $(document).on("knack-view-render.view_1261", function (event, page) { | ||
| // find cabinet ID field div | ||
| var el = $(".field_1789"); | ||
| // find child <a> | ||
| var a = $(el).find("a"); | ||
| // update text | ||
| $(a).addClass("kn-link kn-link-1 kn-link-page kn-button"); | ||
| $(a).html( | ||
| "<span class='icon is-small'><i class='fa fa-list'></i></span><span>Cabinet details</span>" | ||
| ); | ||
| }); |
There was a problem hiding this comment.
This wasn't in here yet.
chiaberry
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some JS that was in the production Data Tracker app but not in the repo. I'll add a comment to that part because the rest is formatting that came from me pasting from the Knack code editor. Trying to get a clean diff for the Knack code for cityofaustin/atd-data-tech#9053, but I didn't realize there was an open pull request that looks kind of stale #78 that could conflict with these updates.
If there is a good reason not to merge this, let me know and I'll stand down. 🙏