Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDS Portal SIF Module CSS Updates #173

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ChrispinP
Copy link
Member

@ChrispinP ChrispinP commented Jan 15, 2025

As part of the SIF Module Updates, these items were updated:

Validation Message Styling
Back Links
Back Buttons
Username field styling
Progress Bar

and Reviewer Dashboard / Vision Team Dashboard stylings removed since we use Task Board now

TDS Portal SIF Assessment Updates
@ChrispinP ChrispinP added enhancement Enhancement to an existing feature or app CSS Modified CSS code Knack Any Knack related PR's labels Jan 15, 2025
@ChrispinP ChrispinP self-assigned this Jan 15, 2025
/**********************************/
/**** Application Progress Bar ****/
/**********************************/
progress { width: 200px; height: 30px; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting

.kn-notification { background-color: #2acee3 !important; font-size: 1.25em; color: black;}
.is-confirmation { background-color: #caf4bc !important; font-size: 1.25em; color: black;}
.is-warning { background-color: #ffe09a !important; font-size: 1.25em; color: black;}
.is-alert { background-color: #ff9b9c !important; font-size: 1.25em; color: black;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check .is-alert

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Susanne, I have addressed this with my second commit so the styling is not overridden. I also simplified the lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example of update:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS properties for font-weight, line-height, border-radius, and border are still on the kn-notification.is-alert form message styling looking at the screenshot above.
image

The line-height for the alert reminder makes the text slightly higher than than the other notification styling. The font-weight is set to 600 for the alert which might give the user the impression that the whole message is bolded instead of just the Reminder: text. You can try font-weight: normal !important; for line 4 (all notifications) or line 8 (just the alert).

The border and border-radius is fine as-is as Knack probably puts that styling for emphasis, but it does make the alert notification bigger than the other notifications as a result since they do not have borders.

I do like the line simplification, looks easier to read and maintain!

This commit updates the Validation language, organization, and code. We also simplify the Modal X lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Modified CSS code enhancement Enhancement to an existing feature or app Knack Any Knack related PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants