dev/core#5584 Fix soft credit default setting & copy down

[eileenmcnaughton]

Overview

this fixes a couple of issues with the soft credit type field in the batch data entry screen

Before

1. back in 2020 the soft_credit_type field was accidentally changed from optional to required as part of an large change which accidentally dropped off a parameter in this line - meaning that $extra is being passed in as $required - this adds the extra $required = FALSE to revert that

2. in addition setting the soft credit contact was causing the soft credit type to be changed to the default value even when it had already been intentionally been set by the user to something else

3. the copy functionality was missing for the soft credit type field
   

4. deprecation warning
   

note that another notice warning fix on this screen was merged to core today - if you see a notice on size you may not have that patch

After

Technical Details

The copy functionality was removed in the course of https://issues.civicrm.org/jira/browse/CRM-12653 but it is not clear that it was intentional - I commented on possible reasons in-code for the fields for the soft credit contact & soft credit amount to have been excluded from the copy down - basically either because of the proximity of the too-hard-basket or because there was an anticipation of new functionality that never happened.

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5584

[mlutfy]

jenkins, test this please

[demeritcowboy]

This seems fine there's just some inconsistency in how soft-credit type works and I'm not sure what it's supposed to be so have put merge-ready:

• On a regular contribution I can leave it blank and it will happily make the soft-credit with no type (maybe this is a bug?)
• Here, if I try to blank it out it appears to let me, but the soft-credit gets created with Solicited type.

[eileenmcnaughton]

@demeritcowboy from my testing it seemed like you had to enter a soft credit amount to have a soft credit created - were you seeing it create a soft credit even when the soft credit amount was not populated?

[demeritcowboy]

No it's that assuming the intent is to allow a soft credit without a type (which would be consistent with the regular contribution form), then you can't do that with this PR because even if you blank out the type field, it creates it with solicited type.

i.e. fill out a batch entry and filling in the soft credit fields, but make the soft credit type blank. When you save, the soft credit has solicited type.