Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Afform] Do not replace multi record custom data on afform submit #31477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devdavc
Copy link
Contributor

@devdavc devdavc commented Nov 14, 2024

Overview

Fixes dev/core#5589
Multiple records custom field set is truncated or "replace" in Form Builder that has dedupe rules for contacts.

Comments

This is an attempt to fix this. Currently not sure if this is reliable. But the idea is to restrict replace on custom data multiple records. Maybe adding a flag to the custom group set might be a better solution, but for now this is the concept.

Copy link

civibot bot commented Nov 14, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Nov 14, 2024
@devdavc devdavc changed the title Do not replace multi record custom data on afform submit [Afform] Do not replace multi record custom data on afform submit Nov 14, 2024
Comment on lines +488 to +489
$values[0]["entity_id"] = $entityId;
$result = civicrm_api4($joinEntityName, 'save', [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to propagate the $entityId into all records, not just the first one. APIv4 has a shorthand way of doing that:

Suggested change
$values[0]["entity_id"] = $entityId;
$result = civicrm_api4($joinEntityName, 'save', [
$result = civicrm_api4($joinEntityName, 'save', [
'defaults' = ['entity_id' => $entityId],

@colemanw
Copy link
Member

Here's a WIP alternative: #31480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants