-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Afform] Do not replace multi record custom data on afform submit #31477
Open
devdavc
wants to merge
1
commit into
civicrm:master
Choose a base branch
from
devdavc:afformMultiRecordCustomData
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
devdavc
changed the title
Do not replace multi record custom data on afform submit
[Afform] Do not replace multi record custom data on afform submit
Nov 14, 2024
colemanw
reviewed
Nov 14, 2024
Comment on lines
+488
to
+489
$values[0]["entity_id"] = $entityId; | ||
$result = civicrm_api4($joinEntityName, 'save', [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to propagate the $entityId
into all records, not just the first one. APIv4 has a shorthand way of doing that:
Suggested change
$values[0]["entity_id"] = $entityId; | |
$result = civicrm_api4($joinEntityName, 'save', [ | |
$result = civicrm_api4($joinEntityName, 'save', [ | |
'defaults' = ['entity_id' => $entityId], |
Here's a WIP alternative: #31480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes dev/core#5589
Multiple records custom field set is truncated or "replace" in Form Builder that has dedupe rules for contacts.
Comments
This is an attempt to fix this. Currently not sure if this is reliable. But the idea is to restrict replace on custom data multiple records. Maybe adding a flag to the custom group set might be a better solution, but for now this is the concept.