Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution Page Widget restructure and cleanup #32120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Feb 18, 2025

Overview

Restructure the layout of the Contribution Page Widget configuration:

  • Remove the top "Configure Widget", other tabs do not have this
  • Checkbox "Enable Widget?" renamed to "Enable the Widget"
  • Removed the warning about Flash
  • About : now optional
  • Show the preview at the top, not in the middle (the colours were oddly separate from the snippet, while being rather important).
  • Colours:
    • No more accordions (ideally the colours would be in a grid, but I could not find a class for it)
    • Moved above the "About" text area because the textarea is huge and it's not really important.
  • "Background Color Top Area" renamed to "Title Background Color"
  • Colours are not required, because in the Contribution Progress extension, I don't need all of them (I'll hide the non-required ones), and besides, it's difficult to make them empty.
  • Removed redundant "Save and Preview" buttons which did nothing special
  • Remove some capt'n obvious help messages

Before

image

image

image

After

image

image

Technical Details

I cheated on the CSS of the widget, because Riverlea does not have what I need here, and it looked a bit weird. This looked better in the old Greenwich, but I don't think it's important enough to spend more time on it.

Comments

Admittedly not perfect, but better than before.

Copy link

civibot bot commented Feb 18, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@mlutfy
Copy link
Member Author

mlutfy commented Feb 18, 2025

Random WIP for the Contribution Progress extension, which provides a different visual:

image

@mlutfy mlutfy force-pushed the contribWidgetCleanup branch from 2286b9f to ec7cf80 Compare February 18, 2025 15:45
@mlutfy
Copy link
Member Author

mlutfy commented Feb 18, 2025

Feedback from @samuelsov : remove the repeat word "Color":

image

I also tweaked a help message, since the "Save and Preview" button is gone:

image

Before:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant