Untested PR: fixes accordion SCSS for Civi > 5.69 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing a major accessibility gap, accordion markup across Civi has been upgraded between 5.69 + 5.72 to make them keyboard and screen-reader friendly. This PR adds the new changes as described in https://lab.civicrm.org/dev/user-interface/-/wikis/DINO:-Notify-themes-+-New-theme/changes-in-5.69, in order to preserve Shoreditch styles on the new accordions. However, I've been unable to fully install Shoreditch to compile these changes into css locally so can't test this PR. However I have tested a largely similar PR in The Island theme: https://lab.civicrm.org/extensions/theisland/-/merge_requests/9.
|
Thanks for the PR @vingle , this will be reviewed and merged as appropriate. |
swastikpareek
added a commit
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, but offered to resolve UI issues on Civi installs after 5.69.
Closing a major accessibility shortfall, accordion markup across Civi has been upgraded between 5.69 + 5.72 to make them keyboard and screen-reader friendly.
This PR adds the new changes as described in https://lab.civicrm.org/dev/user-interface/-/wikis/DINO:-Notify-themes-+-New-theme/changes-in-5.69, in order to preserve Shoreditch styles on the new accordions.
However, I've been unable to fully install Shoreditch to compile these changes into css locally so can't test this PR. However I have tested a largely similar PR in The Island theme: https://lab.civicrm.org/extensions/theisland/-/merge_requests/9.
Before
Accordions match Greenwich styling…
After
They don't…
Technical Details
Screengrabs are from the changes in The Island, and reflect the expected appearance after testing.