Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve representative frame getter #281

Closed
keighrim opened this issue Jun 6, 2024 · 0 comments · Fixed by #291
Closed

improve representative frame getter #281

keighrim opened this issue Jun 6, 2024 · 0 comments · Fixed by #291

Comments

@keighrim
Copy link
Member

keighrim commented Jun 6, 2024

can we provide an argument to set the rule to pick the "top"? I'm thinking of

  1. get all fnums from all elements in the rep list.
  2. get the fnum of the first rep element (as a single list maybe, only to keep the return type simple)
  3. get the fnum of the "middle" rep element

We might need to think more carefully how this argument can be propagated in the following extract_representative_frame wrapper fn.

Originally posted by @keighrim in #278 (comment)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant