Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving representative frame extraction #291

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

keighrim
Copy link
Member

fixes #281.

@keighrim keighrim requested a review from kelleyl July 12, 2024 19:00
@keighrim
Copy link
Member Author

@kelleyl this PR might break existing code of yours. Can you review the code and maybe test it (with pip install -e .) against your app code?

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.48%. Comparing base (af83e13) to head (ab40d2b).
Report is 4 commits behind head on develop.

Files Patch % Lines
mmif/utils/video_document_helper.py 80.76% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
- Coverage    92.63%   92.48%   -0.15%     
===========================================
  Files           10       10              
  Lines         1384     1398      +14     
===========================================
+ Hits          1282     1293      +11     
- Misses         102      105       +3     
Flag Coverage Δ
unittests 92.48% <80.76%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keighrim keighrim force-pushed the 281-improved-rep-frame-extr branch from bd5d538 to d085cfb Compare July 29, 2024 19:54
@keighrim keighrim merged commit e776810 into develop Aug 21, 2024
1 of 3 checks passed
@keighrim keighrim deleted the 281-improved-rep-frame-extr branch August 21, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

improve representative frame getter
1 participant