Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of extract_frames_as_images destory input frame #303

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

1192119703jzx
Copy link
Contributor

fixes #302

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (2e17432) to head (c94106c).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
+ Coverage    90.74%   92.63%   +1.88%     
===========================================
  Files           10       10              
  Lines         1383     1384       +1     
===========================================
+ Hits          1255     1282      +27     
+ Misses         128      102      -26     
Flag Coverage Δ
unittests 92.63% <100.00%> (+1.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keighrim
Copy link
Member

@1192119703jzx could you also some sanity checks (and maybe some edge case handling?) to the test suite, around here

?

@keighrim keighrim merged commit af83e13 into develop Aug 21, 2024
3 checks passed
@keighrim keighrim deleted the 302-vdh-destroy-frame-list branch August 21, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Video helper destroying input frame list
2 participants