Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from tslint to eslint #155

Closed

Conversation

Technickel-Dev
Copy link
Contributor

tslint is depreciated so this push implements eslint following the steps highlighted here! This will close #149.

All changes are tested, but you can run the lint with npm run lint or using the associated vscode task.

image

Besides the migration changes, I had to update the typescript version because we were way behind and it didn't work with eslint. I went ahead and fixed (or ignored if it was not really a problem) all the current linting problem and formatted all the files based on the .editorconfig to get a nice clean slate to work with

Side note: package-lock.json did some required version updating again since #153 isn't fully merge. I wanted to wait till that's in fully, so I'll come back and merge things up when that's pushed through. Ultimately, this push shouldn't change anything functionality wise in general, all code styles.

@clarkio
Copy link
Owner

clarkio commented Nov 25, 2022

@Technickel-Dev I'm really appreciative of the work you put into this PR as well. After reviewing it further I think we're headed in the right direction with these changes however I'd like to slim it down regarding how much is being changed through the eslint rules.

What I'm thinking is for this PR we just include changes to migrate to eslint from tslint but not apply any linting changes. It might mean we need to modify the eslint rules to accomplish that. Essentially 1 PR for moving between linting tools and then 1 PR for each new linting change based on rules we want to adhere to.

For example I'm good with moving to single quotes from double quotes but let's put that in a separate PR to make it more manageable. Does that make sense to you as well? What do you think?

@Technickel-Dev
Copy link
Contributor Author

Agreed, looking back I'm only realizing now what a pain this would be to review. Will break up the PR when I get the chance, stay tuned!

@Technickel-Dev Technickel-Dev deleted the migrate-tslint-to-eslint branch December 28, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from tslint to eslint
2 participants