implement SliceableRepository #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,7 @@ | |||
| <logger name="org.springframework" level="INFO" /> | |||
| <logger name="jp.xet.springframework.data.mirage" level="DEBUG" /> | |||
|
|
|||
| <logger name="com.miragesql.miragesql" level="WARN" /> | |||
| <logger name="com.miragesql.miragesql" level="DEBUG" /> | |||
There was a problem hiding this comment.
test 時は 発行する SQL が見えた方が良いと思われた
katagiri-kazumune
requested review from
daisuke-fujimura-classmethod and
inabajunmr
inabajunmr
approved these changes
Mar 24, 2020
| Class<?> returnedDomainType, SliceableParameterAccessor accessor) { | ||
| Sliceable sliceable = accessor.getSliceable(); | ||
| if (sliceable != null) { | ||
| addSliceParam(parameterMap, sliceable); | ||
| } else if (accessor.getSort() != null) { |
There was a problem hiding this comment.
このアクセサからソートが取得できたときのsortなんですが、sliceableがなかった時のelseの場合だけ適用されるの中途半端な気がしていて、sliceableでかつsort、みたいなことができないのであればとりあえずこのsliceableがなかったらsort、はなくてもよいかなと思いました（なんか違う意図があったら教えてもらえると）
There was a problem hiding this comment.
消しました(多分 Sort パラメータの存在を知ってる人はいない)
26bf016
| /** | ||
| * SliceableRepository のメソッド定義無し. | ||
| */ | ||
| public interface TaskRepository extends WritableRepository<Task, String>, SliceableRepository<Task, String> { |
There was a problem hiding this comment.
なんとなくTaskSliceableRepositoryのが規則性がある感じがしました
There was a problem hiding this comment.
修正しました
26bf016
|
@inabajunmr |
katagiri-kazumune
modified the milestones:
0.14.4.RELEASE,
0.14.5.RELEASE,
0.14.6.RELEASE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
#2
classmethod/spar-wings#6 の対応済みの spar-wings が必要
内容
SliceableRepository#findAll や
メソッドの戻り値に Slice を指定したメソッドに対して
Slice 形式の結果を返す