Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecation warnings and fix websockets in asgi #97

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

claws
Copy link
Owner

@claws claws commented Dec 27, 2023

  • fixed aiohttp deprecation warnings. Affected files:

    • src/aioprometheus/service.py
    • tests/test_aiohttp.py
  • fix pylint warnings. Affected files:

    • examples/service/app-service-example.py
    • examples/decorators/decorator_count_exceptions.py
    • examples/decorators/decorator_inprogress.py
    • examples/decorators/decorator_timer.py
    • src/aioprometheus/mypy_types.py
    • src/aioprometheus/collectors.py
    • src/aioprometheus/renderer.py
    • src/aioprometheus/asgi/middleware.py
  • incorporates added "websocket" to scope check #94 (fixes websocket support in quart #93) which supports websockets in asgi frameworks. Affected files:

    • src/aioprometheus/service.py
  • bump version to 23.12.0

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4786678) 95.96% compared to head (1e3aef2) 95.96%.

Files Patch % Lines
src/aioprometheus/asgi/middleware.py 75.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files          16       16           
  Lines         718      719    +1     
  Branches       93       93           
=======================================
+ Hits          689      690    +1     
  Misses         15       15           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claws claws merged commit 2fabe65 into master Dec 27, 2023
4 checks passed
@claws claws deleted the dec2023 branch December 27, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

websocket support in quart
2 participants