-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs Build Script #2041
Draft
NWylynko
wants to merge
43
commits into
main
Choose a base branch
from
nick/docs-build-step
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Docs Build Script #2041
+5,914
−2,022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…<SignIn /> component regardless of if they have an example
…ectPage /> component
…r the users active SDK
…t not available based on manifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds script validates
And then it generates out a new
dist
folder<If />
component has been used it filters out section that don't apply to the sdk<Partials />
gets embedded, this should help load times in cache miss situations<SDKLink />
component gets placed in markdown files that links to sdk specific guides<SDKDocRedirectPage />
component gets placed in guide landing page, to direct the user towards a sdk specific versionThis is run on every push in a github action to help lint for authors and to build the dist package for clerk.com to use.
Authors can run
npm run build
locally to use itTODO:
This is all to enable sdk based filtering at a fine-grained control. The goal is:
Starting from the top:
the "sdk" key value pair in the manifest.json file
the "sdk" key value pair in the frontmatter of a guide
The component
There is no requirement to use filter 3 to use 2 or using 1 to use 3, all three should be optional tools to achieve the docs we are aiming for. But the filtering down should follow a logical order.