Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js): Launch sign-in-or-up flow #4788

Merged
merged 52 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
8ed1cc9
chore: remove experimental check
alexcarpenter Dec 16, 2024
273f234
check for empty signUpUrl
alexcarpenter Dec 16, 2024
37f3f57
Update SignInProps
alexcarpenter Dec 16, 2024
79cadb9
update checks
alexcarpenter Dec 16, 2024
59b519b
merge
alexcarpenter Jan 9, 2025
3b63877
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
jacekradko Jan 9, 2025
454f1cf
add changeset
alexcarpenter Jan 9, 2025
ec51e41
update tests
alexcarpenter Jan 9, 2025
aa0245a
fix path
alexcarpenter Jan 9, 2025
efc25c1
remove sign_up_url
alexcarpenter Jan 9, 2025
11f257d
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter Jan 10, 2025
8320207
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter Jan 10, 2025
39aae7d
feat(clerk-js,react,types): Add option to enable combined flow at com…
alexcarpenter Jan 13, 2025
d26ff82
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter Jan 13, 2025
5dc7940
refactor(e2e): Update sign-in-or-up tests (#4872)
alexcarpenter Jan 14, 2025
042d101
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter Jan 14, 2025
a549423
add express tag
alexcarpenter Jan 14, 2025
0e6fbcb
move back to protected page test
alexcarpenter Jan 14, 2025
d7e2383
remove combined props usage
alexcarpenter Jan 14, 2025
a8deaa3
fix(clerk-js): Use correct email link redirect_url based on intent (#…
dstaley Jan 14, 2025
130f17c
Merge branch 'alexcarpenter/sign-in-or-up-ga' of github.com:clerk/jav…
alexcarpenter Jan 14, 2025
d516c26
fix email link paths
alexcarpenter Jan 14, 2025
e14de2a
Update packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
alexcarpenter Jan 15, 2025
055fdb7
Update packages/clerk-js/src/ui/common/redirects.ts
alexcarpenter Jan 15, 2025
361cf90
Update packages/clerk-js/src/ui/contexts/components/SignIn.ts
alexcarpenter Jan 15, 2025
8136c40
Merge branch 'alexcarpenter/sign-in-or-up-ga' of github.com:clerk/jav…
alexcarpenter Jan 15, 2025
c77b8e7
format
alexcarpenter Jan 15, 2025
68324d7
bring back fallback
alexcarpenter Jan 15, 2025
4545e77
fix(nextjs): Handle dynamicIO errors when request apis are accessed o…
panteliselef Jan 14, 2025
b38298d
fix(localizations): Force interpolation for `socialButtonsBlockButton…
panteliselef Jan 15, 2025
5c842f8
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
LekoArts Jan 15, 2025
5b82f80
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
jacekradko Jan 15, 2025
e0f4a6e
Delete .changeset/cuddly-shrimps-fold.md
alexcarpenter Jan 15, 2025
e1aef02
add changeset
alexcarpenter Jan 15, 2025
b8941e8
Merge branch 'alexcarpenter/sign-in-or-up-ga' of github.com:clerk/jav…
alexcarpenter Jan 15, 2025
cd9a4a4
Delete .changeset/two-doors-visit.md
alexcarpenter Jan 15, 2025
8a33145
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
jacekradko Jan 15, 2025
6e8a4ab
Update .changeset/tough-bugs-vanish.md
alexcarpenter Jan 15, 2025
bee4012
add withSignUp prop to vue SignInButton
alexcarpenter Jan 15, 2025
f559bd1
Update .changeset/tough-bugs-vanish.md
alexcarpenter Jan 15, 2025
ae62b50
remove combinedFlow prop from provider
alexcarpenter Jan 15, 2025
25ff0df
Merge branch 'alexcarpenter/sign-in-or-up-ga' of github.com:clerk/jav…
alexcarpenter Jan 15, 2025
183a626
fix(clerk-js): Preserve __clerk_ticket for internal sign-in navigatio…
brkalow Jan 15, 2025
51074b6
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter Jan 15, 2025
c1d59b5
fix test
alexcarpenter Jan 16, 2025
6458707
remove email link test changes
alexcarpenter Jan 16, 2025
9c2dd6b
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter Jan 16, 2025
658a7bf
temp disable email link tests
alexcarpenter Jan 16, 2025
f730990
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
jacekradko Jan 16, 2025
f1db0e5
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter Jan 16, 2025
63162f6
Update SignInButton.vue
alexcarpenter Jan 16, 2025
e1772b3
Fix vue options passing.
brkalow Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/tough-bugs-vanish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@clerk/clerk-js': minor
'@clerk/clerk-react': minor
'@clerk/types': minor
alexcarpenter marked this conversation as resolved.
Show resolved Hide resolved
'@clerk/vue': minor
---

Introduce sign-in-or-up flow.
18 changes: 10 additions & 8 deletions integration/presets/envs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,15 @@ const withWaitlistdMode = withEmailCodes
.setEnvVariable('private', 'CLERK_SECRET_KEY', instanceKeys.get('with-waitlist-mode').sk)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', instanceKeys.get('with-waitlist-mode').pk);

const withCombinedFlow = withEmailCodes
const withSignInOrUpFlow = withEmailCodes
.clone()
.setId('withCombinedFlow')
.setEnvVariable('private', 'CLERK_SECRET_KEY', instanceKeys.get('with-email-codes').sk)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', instanceKeys.get('with-email-codes').pk)
.setEnvVariable('public', 'EXPERIMENTAL_COMBINED_FLOW', 'true')
.setEnvVariable('public', 'CLERK_SIGN_IN_URL', '/sign-in')
.setEnvVariable('public', 'CLERK_SIGN_UP_URL', '/sign-in');
.setId('withSignInOrUpFlow')
.setEnvVariable('public', 'CLERK_SIGN_UP_URL', undefined);

const withSignInOrUpEmailLinksFlow = withEmailLinks
.clone()
.setId('withSignInOrUpEmailLinksFlow')
.setEnvVariable('public', 'CLERK_SIGN_UP_URL', undefined);

export const envs = {
base,
Expand All @@ -138,5 +139,6 @@ export const envs = {
withRestrictedMode,
withLegalConsent,
withWaitlistdMode,
withCombinedFlow,
withSignInOrUpFlow,
withSignInOrUpEmailLinksFlow,
} as const;
7 changes: 6 additions & 1 deletion integration/presets/longRunningApps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,12 @@ export const createLongRunningApps = () => {
},
{ id: 'next.appRouter.withCustomRoles', config: next.appRouter, env: envs.withCustomRoles },
{ id: 'next.appRouter.withReverification', config: next.appRouter, env: envs.withReverification },
{ id: 'next.appRouter.withCombinedFlow', config: next.appRouter, env: envs.withCombinedFlow },
{ id: 'next.appRouter.withSignInOrUpFlow', config: next.appRouter, env: envs.withSignInOrUpFlow },
{
id: 'next.appRouter.withSignInOrUpEmailLinksFlow',
config: next.appRouter,
env: envs.withSignInOrUpEmailLinksFlow,
},
{ id: 'quickstart.next.appRouter', config: next.appRouterQuickstart, env: envs.withEmailCodesQuickstart },
{ id: 'elements.next.appRouter', config: elements.nextAppRouter, env: envs.withEmailCodes },
{ id: 'astro.node.withCustomRoles', config: astro.node, env: envs.withCustomRoles },
Expand Down
3 changes: 0 additions & 3 deletions integration/templates/next-app-router/src/app/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ export default function RootLayout({ children }: { children: React.ReactNode })
return (
<ClerkProvider
experimental={{
combinedFlow: process.env.NEXT_PUBLIC_EXPERIMENTAL_COMBINED_FLOW
? process.env.NEXT_PUBLIC_EXPERIMENTAL_COMBINED_FLOW === 'true'
: undefined,
persistClient: process.env.NEXT_PUBLIC_EXPERIMENTAL_PERSIST_CLIENT
? process.env.NEXT_PUBLIC_EXPERIMENTAL_PERSIST_CLIENT === 'true'
: undefined,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { SignIn } from '@clerk/nextjs';

export default function Page() {
return (
<div>
<SignIn
routing={'path'}
path={'/sign-in'}
dstaley marked this conversation as resolved.
Show resolved Hide resolved
signUpUrl={'/sign-up'}
fallback={<>Loading sign in</>}
withSignUp
/>
</div>
);
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ export default function Page() {
path={'/sign-in'}
signUpUrl={'/sign-up'}
fallback={<>Loading sign in</>}
__experimental={{
combinedProps: {},
}}
/>
</div>
);
Expand Down
160 changes: 0 additions & 160 deletions integration/tests/combined-sign-in-flow.test.ts

This file was deleted.

122 changes: 0 additions & 122 deletions integration/tests/combined-sign-up-flow.test.ts

This file was deleted.

Loading
Loading