Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): Upgrade eslint@9 #4842

Merged
merged 10 commits into from
Jan 23, 2025
Merged

feat(repo): Upgrade eslint@9 #4842

merged 10 commits into from
Jan 23, 2025

Conversation

jacekradko
Copy link
Member

@jacekradko jacekradko commented Jan 7, 2025

Description

https://eslint.org/docs/latest/use/migrate-to-9.0.0

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 781925a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 6:06pm

@jacekradko jacekradko changed the title feat(repo): eslint@9 feat(repo): Upgrade eslint@9 Jan 23, 2025
@@ -1,20 +0,0 @@
**/coverage/**
Copy link
Member Author

@jacekradko jacekradko Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.eslintignore files are obsolete and no longer have any effect. This is now set in eslint.config.mjs

@@ -1,4 +0,0 @@
module.exports = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All configurations are now in the root eslint.config.mjs file

"lint:attw": "FORCE_COLOR=1 turbo lint:attw",
"lint:fix": "FORCE_COLOR=1 turbo lint -- --fix",
"lint:inspect": "pnpx @eslint/config-inspector@latest",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great way to find out what rules apply to specific files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

til!

@jacekradko jacekradko marked this pull request as ready for review January 23, 2025 03:51
@@ -8,7 +8,6 @@ export * from './components';
export * from './contexts';

export * from './hooks';
export { useEmailLink } from './hooks/useEmailLink';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for myself: Removal is fine since the splat export above covers it

@@ -20,7 +20,6 @@ export * from './deprecated';
export { deriveState } from './deriveState';
export * from './error';
export * from './file';
export { handleValueOrFn } from './utils/handleValueOrFn';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be fine with #4972 merged now 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duped export

Screenshot 2025-01-23 at 9 17 27 AM

@@ -36,4 +35,3 @@ export * from './object';
export * from './logger';
export { createWorkerTimers } from './workerTimers';
export { DEV_BROWSER_JWT_KEY, extractDevBrowserJWTFromURL, setDevBrowserJWTInURL } from './devBrowser';
export { fastDeepMergeAndKeep, fastDeepMergeAndReplace } from './utils/fastDeepMerge';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require the same treatment as #4972, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another duped export

Screenshot 2025-01-23 at 9 23 01 AM

@jacekradko jacekradko merged commit 8a8eb6d into main Jan 23, 2025
29 checks passed
@jacekradko jacekradko deleted the feat/eslint branch January 23, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants