-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repo): Upgrade eslint@9 #4842
Conversation
🦋 Changeset detectedLatest commit: 781925a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -1,20 +0,0 @@ | |||
**/coverage/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.eslintignore
files are obsolete and no longer have any effect. This is now set in eslint.config.mjs
@@ -1,4 +0,0 @@ | |||
module.exports = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All configurations are now in the root eslint.config.mjs
file
"lint:attw": "FORCE_COLOR=1 turbo lint:attw", | ||
"lint:fix": "FORCE_COLOR=1 turbo lint -- --fix", | ||
"lint:inspect": "pnpx @eslint/config-inspector@latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great way to find out what rules apply to specific files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
til!
@@ -8,7 +8,6 @@ export * from './components'; | |||
export * from './contexts'; | |||
|
|||
export * from './hooks'; | |||
export { useEmailLink } from './hooks/useEmailLink'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for myself: Removal is fine since the splat export above covers it
@@ -20,7 +20,6 @@ export * from './deprecated'; | |||
export { deriveState } from './deriveState'; | |||
export * from './error'; | |||
export * from './file'; | |||
export { handleValueOrFn } from './utils/handleValueOrFn'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should be fine with #4972 merged now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -36,4 +35,3 @@ export * from './object'; | |||
export * from './logger'; | |||
export { createWorkerTimers } from './workerTimers'; | |||
export { DEV_BROWSER_JWT_KEY, extractDevBrowserJWTFromURL, setDevBrowserJWTInURL } from './devBrowser'; | |||
export { fastDeepMergeAndKeep, fastDeepMergeAndReplace } from './utils/fastDeepMerge'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would require the same treatment as #4972, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
https://eslint.org/docs/latest/use/migrate-to-9.0.0
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change