Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react-router): Bump react-router peer dependency #4917

Merged
merged 4 commits into from
Jan 17, 2025
Merged

chore(react-router): Bump react-router peer dependency #4917

merged 4 commits into from
Jan 17, 2025

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Jan 16, 2025 •
edited
Loading

Description

This PR bumps react-router peer dependency to ^7.1.2 for upstream context mismatch fix.

Fixes #4826

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: eae51d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/react-router Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:16am

@wobsoriano wobsoriano changed the title fix(react-router): Fix context mismatch issue fix(react-router): Bump peer dependency for context mismatch fix Jan 16, 2025
@wobsoriano wobsoriano changed the title fix(react-router): Bump peer dependency for context mismatch fix chore(react-router): Bump peer dependency for context mismatch fix Jan 16, 2025
@wobsoriano wobsoriano marked this pull request as ready for review January 16, 2025 22:10
@wobsoriano wobsoriano requested a review from LekoArts January 16, 2025 22:10
@wobsoriano wobsoriano changed the title chore(react-router): Bump peer dependency for context mismatch fix chore(react-router): Bump react-router peer dependency Jan 16, 2025
@wobsoriano wobsoriano changed the title chore(react-router): Bump react-router peer dependency chore(react-router): Bump react-router peer dependency Jan 16, 2025
LekoArts
LekoArts approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the package is still marked as "Beta" and we're in v0.x range the bump is fine in a minor (normally you'd do a major)

@LekoArts LekoArts enabled auto-merge (squash) January 17, 2025 10:15
@LekoArts LekoArts merged commit 8788dcd into main Jan 17, 2025
29 checks passed
@LekoArts LekoArts deleted the rob/fix-react-router-context-issue branch January 17, 2025 10:23
@clerk-cookie clerk-cookie mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
integration playground react-router
Projects
None yet
Milestone
No milestone
3 participants
@wobsoriano @LekoArts @clerk-cookie