chore(nextjs): Decrease frequency of logs related to Keyless #4953
+86
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b4aae34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
anagstef
approved these changes
Jan 21, 2025
anagstef
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On nextjs during development, we need to "log once" at most every X minutes. Our logger from
@clerk/shared/loggerwill not work, because variables defined at a module scope get re-initialized when HMR runs.To address that I created
global.__clerk_internal_keyless_logger, currently is intended to be used only for the keyless feature, but we can generalise it later if and when another part of our integration can benefit from it.I considered using
unstable_cachefor this which works, but the api is unstable, and will be transitioning to "use cache" in the future.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change