Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Mark keyless onboarding as complete when stored keys match explicit keys #4971

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Jan 22, 2025

Description

Calling completeAccountlessApplicationOnboarding will notify the dashboard to automatically proceed from step 2, to step 3 on the claim flow.

Step 2 Step 3
image image

Since this is called inside ClerkProvider, we can to avoid making a BAPI request frequently. When the request successfully resolved, we are caching it for 24 hours, otherwise in case of an error it will be cached only for 10 minutes.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@panteliselef panteliselef self-assigned this Jan 22, 2025
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 0:12am

Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 2578096

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@clerk/backend Patch
@clerk/nextjs Patch
@clerk/astro Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/tanstack-start Patch
@clerk/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef merged commit 4773d0a into main Jan 28, 2025
31 checks passed
@panteliselef panteliselef deleted the elef/actls-68-notify-dashboard-that-the-developer-has-explicitly-set-the branch January 28, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants