fix(clerk-js): Ensure only one action is present within EmailSection UI #5023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 53b4de4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…remains-in-place-even-if-the-email-is
alexcarpenter
commented
Jan 28, 2025
Comment on lines
+7
to
+11
| type ActionRootProps = PropsWithChildren<{ | ||
| animate?: boolean; | ||
| value?: string | null; | ||
| onChange?: (value: string | null) => void; | ||
| }>; |
There was a problem hiding this comment.
Introduce options to be able to make Action.Root a controlled component.
jacekradko
reviewed
Jan 28, 2025
packages/clerk-js/src/ui/components/UserProfile/EmailsSection.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacek Radko <[email protected]>
|
Closing in favor of #5030 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BEFORE
Screen.Recording.2025-01-28.at.1.20.40.PM.mov
AFTER
Screen.Recording.2025-01-28.at.1.19.27.PM.mov
Fixes SDKI-817
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change