Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nextjs): E2E tests for middleware file placement #5037

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Jan 29, 2025

Description

Adds e2e tests for #5028, but also changes useTemplate() to completely override the previous selection. Before it would merge them.

Fixes ACTLS-63

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@panteliselef panteliselef requested a review from a team January 29, 2025 14:04
@panteliselef panteliselef self-assigned this Jan 29, 2025
Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 02e2780

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 7:49pm

@panteliselef panteliselef merged commit fe89e62 into main Jan 31, 2025
29 checks passed
@panteliselef panteliselef deleted the elef/e2e-middleware-placement branch January 31, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants