-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Ruby 3 #20
Merged
Update to Ruby 3 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove combinations that are not supported Ruby vs AR
peerkleio
requested review from
gavingmiller,
ChrisNJ58,
Drew-Goddyn and
anthonyoconnorclio
and removed request for
gavingmiller
June 10, 2024 19:29
Drew-Goddyn
reviewed
Jun 10, 2024
- 6.1.0 | ||
- 7.0.0 | ||
- 7.1.0 | ||
exclude: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Drew-Goddyn
approved these changes
Jun 10, 2024
anthonyoconnorclio
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the gem to use Ruby v3. This also updates the CI runs to use multiple versions of Ruby and ActiveRecord while excluding incompatible versions (e.g. Ruby 3.2 won't work with Rails 6.1)
Other code changes that were necessary,
update_attributes
withupdate_attribute
as the former has been deprecated.ActiveRecord::MigrationContext
with additional argument required for v6.1ActiveSupport::Dependencies.constantize(lookup)
tolookup.constantize