Code

Merge public main into Clio fork#33

Code

Open

robin-phung wants to merge 155 commits intomasterclio/split:masterfrom splitrb-mainclio/split:splitrb-mainCopy head branch name to clipboard

+2,280-2,501

Commits

Commits on Apr 11, 2020

• Add on_winner_choose hook

  macgena

  committed
  c6a0d76

  Copy full SHA for c6a0d76

• Update winner choose hook name

  macgena

  committed
  ce0e62b

  Copy full SHA for ce0e62b

• Merge pull request splitrb#574 from Nootrobox/add-on-winner-choose-hook

  Show description for 25f6330
  andrehjr

  authored
  25f6330

  Copy full SHA for 25f6330

Commits on May 4, 2020

• Fix #max_experiments_reached? when using allow_multiple_experiments=control

  Show description for 0d2178e
  andrehjr

  committed
  0d2178e

  Copy full SHA for 0d2178e

• Merge pull request splitrb#613 from splitrb/fix-allow_multiple_experiments-control-with-versions

  Show description for f48c196
  andrehjr

  authored
  f48c196

  Copy full SHA for f48c196

Commits on May 7, 2020

• Replace usage of SimpleRandom with RubyStats

  andrehjr

  committed
  036374e

  Copy full SHA for 036374e

• Merge pull request splitrb#616 from splitrb/rubystats-for-beta-distribution

  Show description for d3ef9d7
  andrehjr

  authored
  d3ef9d7

  Copy full SHA for d3ef9d7

Commits on May 13, 2020

• removed unreached loading from config

  robin-phung

  committed
  648576a

  Copy full SHA for 648576a

• Merge pull request splitrb#619 from robin-phung/cleanup-experiment-init

  Show description for 0eab0ae
  andrehjr

  authored
  0eab0ae

  Copy full SHA for 0eab0ae

Commits on May 20, 2020

• ab_test must return metadata on error or if split is disabled

  andrehjr

  committed
  de61579

  Copy full SHA for de61579

• Merge pull request splitrb#622 from splitrb/consistent-return-metadata-when-disabled

  Show description for 261013c
  andrehjr

  authored
  261013c

  Copy full SHA for 261013c

Commits on May 27, 2020

• Introduce enable/disable experiment cohorting

  robin-phung

  committed
  f9fc878

  Copy full SHA for f9fc878

• disable cohorting revision

  robin-phung

  committed
  0dcc853

  Copy full SHA for 0dcc853

• Merge pull request splitrb#615 from robin-phung/master

  Show description for 482e700
  andrehjr

  authored
  482e700

  Copy full SHA for 482e700

Commits on Jun 3, 2020

• Update trial to init with goals instead

  robin-phung

  committed
  00748fd

  Copy full SHA for 00748fd

Commits on Jun 4, 2020

• spec copy change

  robin-phung

  committed
  18622a5

  Copy full SHA for 18622a5

• Merge pull request splitrb#625 from robin-phung/trial-goal-callback

  Show description for 9e45dd1
  andrehjr

  authored
  9e45dd1

  Copy full SHA for 9e45dd1

Commits on Jun 18, 2020

• Only suport ruby 2.5+

  andrehjr

  committed
  4b388f7

  Copy full SHA for 4b388f7

• Add ruby 2.7 to the matrix

  andrehjr

  committed
  9ae7610

  Copy full SHA for 9ae7610

• Merge pull request splitrb#627 from splitrb/bump-ruby-support-to-2-5-plus

  Show description for 38058d3
  andrehjr

  authored
  38058d3

  Copy full SHA for 38058d3

• Change redis.exists to redis.exists? to avoid problems with redis 4.3

  

  cesarizu

  authored and

  andrehjr

  committed
  1222565

  Copy full SHA for 1222565

• Bump minimum required redis version

  andrehjr

  committed
  1f5cb04

  Copy full SHA for 1f5cb04

• hset behavior changed on redis-rb, removing redundant specs

  andrehjr

  committed
  0111694

  Copy full SHA for 0111694

• Use a real redis-server on CI

  andrehjr

  committed
  b93a485

  Copy full SHA for b93a485

• Merge pull request splitrb#628 from splitrb/bump-minimum-required-redis

  Show description for 1db141c
  andrehjr

  authored
  1db141c

  Copy full SHA for 1db141c

Commits on Jun 19, 2020

• Update CHANGELOG.md

  andrehjr

  committed
  eefce9a

  Copy full SHA for eefce9a

Commits on Jun 22, 2020

• Remove thread_safe config as redis-rb is thread_safe by default since 2.2

  andrehjr

  committed
  41502b2

  Copy full SHA for 41502b2

• Remove redis_url impl. Deprecated on ~2.2

  andrehjr

  committed
  cc816b3

  Copy full SHA for cc816b3

• Merge pull request splitrb#630 from splitrb/remove-old-redis-config

  Show description for 508c1d0
  andrehjr

  authored
  508c1d0

  Copy full SHA for 508c1d0

• Merge pull request splitrb#631 from splitrb/remove-deprecated-redis-url

  Show description for 1895104
  andrehjr

  authored
  1895104

  Copy full SHA for 1895104

• Remove unused RedisInterface#remove_last_item_from_list

  andrehjr

  committed
  fcd51dc

  Copy full SHA for fcd51dc

• Simplify list persistence on RedisInterface

  andrehjr

  committed
  593a8d0

  Copy full SHA for 593a8d0

• Remove extra SISMEMBER check when calling RedisInterface#add_to_set

  andrehjr

  committed
  7b9caf5

  Copy full SHA for 7b9caf5

• update rubocop_todo.yml

  andrehjr

  committed
  f062def

  Copy full SHA for f062def

• Merge pull request splitrb#632 from splitrb/simplify-redis-interface

  Show description for 7ec1015
  andrehjr

  authored
  7ec1015

  Copy full SHA for 7ec1015

• update changelog

  andrehjr

  committed
  bb99568

  Copy full SHA for bb99568

Commits on Jul 5, 2020

• Recreate rubocop configuration

  andrehjr

  committed
  50e7359

  Copy full SHA for 50e7359

• Removes metadata key when it updated to nil

  andrehjr

  committed
  2c151af

  Copy full SHA for 2c151af

• Merge pull request splitrb#633 from splitrb/fix-metadata-updates

  Show description for b6a46a1
  andrehjr

  authored
  b6a46a1

  Copy full SHA for b6a46a1

• Fix Rubocop offense Layout/EmptyLineAfterMagicComment

  andrehjr

  committed
  d3e0f40

  Copy full SHA for d3e0f40

• Add description to what split stores in cookies

  andrehjr

  committed
  a5a3285

  Copy full SHA for a5a3285

• Merge pull request splitrb#634 from splitrb/add-documentation-on-cookie-storage

  Show description for 8114493
  andrehjr

  authored
  8114493

  Copy full SHA for 8114493

Commits on Aug 8, 2020

• Force experiment does not count for metrics

  Show description for 12390b8
  andrehjr

  committed
  12390b8

  Copy full SHA for 12390b8

• Merge pull request splitrb#637 from splitrb/rewrite-force-option

  Show description for 10fff35
  andrehjr

  authored
  10fff35

  Copy full SHA for 10fff35

• Remove Sinatra Dependency for Split Dashboard

  

  Paulo Casaretto

  authored and

  andrehjr

  committed
  3a9da74

  Copy full SHA for 3a9da74

Commits on Aug 10, 2020

• Implement usage of middlewares on new rack app

  andrehjr

  committed
  20ec72d

  Copy full SHA for 20ec72d

• Merge pull request splitrb#635 from splitrb/sinatra-has-left-the-building

  Show description for 3190356
  andrehjr

  authored
  3190356

  Copy full SHA for 3190356

• Fix Layout/SpaceAfterComma offenses

  andrehjr

  committed
  cb6dfde

  Copy full SHA for cb6dfde

Commits on Aug 22, 2020

• Alternative as Sets were deprecated on 0.x

  andrehjr

  committed
  278e89e

  Copy full SHA for 278e89e

• Merge pull request splitrb#639 from splitrb/remove-old-alternatives-set-compat-code

  Show description for 1f730d4
  andrehjr

  authored
  1f730d4

  Copy full SHA for 1f730d4

Commits on Aug 23, 2020

• shorten multiples hsets into a single hmset

  andrehjr

  committed
  930873f

  Copy full SHA for 930873f

• Merge pull request splitrb#640 from splitrb/reduce-extra-hset-call

  Show description for 5e1f3b6
  andrehjr

  authored
  5e1f3b6

  Copy full SHA for 5e1f3b6

Commits on Sep 1, 2020

• Revert "Remove Sinatra Dependency for Split Dashboard"

  andrehjr

  committed
  3cd4ec3

  Copy full SHA for 3cd4ec3

Commits on Sep 2, 2020

• add a simple way to load users outside web session

  andrehjr

  committed
  e5c1534

  Copy full SHA for e5c1534

• Merge pull request splitrb#642 from splitrb/outside-web-sessions

  Show description for 595a59a
  andrehjr

  authored
  595a59a

  Copy full SHA for 595a59a

Commits on Oct 21, 2020

• Fix typo of in Split::Trial class variable

  Show description for 5ee828c
  TomasBarry

  committed
  5ee828c

  Copy full SHA for 5ee828c

• Merge pull request splitrb#644 from TomasBarry/typo/correct-spelling-of-class-variable-in-trial

  Show description for 00d76dc
  andrehjr

  authored
  00d76dc

  Copy full SHA for 00d76dc

Commits on Nov 24, 2020

• Added in-memory cache for ExperimentCatalog#find

  rdh

  committed
  da021ef

  Copy full SHA for da021ef

• Added cache_catalog config

  rdh

  committed
  e050109

  Copy full SHA for e050109

• Added Split::Cache with config and spec, and wired into a few places

  rdh

  committed
  80704b1

  Copy full SHA for 80704b1

• Add disable_metrics config to short circuit metrics lookup in Redis

  rdh

  committed
  4828094

  Copy full SHA for 4828094

• Back out Split.configuration.disable_metrics

  rdh

  committed
  e2c265c

  Copy full SHA for e2c265c

Commits on Dec 3, 2020

• Remove obsolete cache clear left over from before refactoring

  rdh

  committed
  623e556

  Copy full SHA for 623e556

Commits on Dec 4, 2020

• Added docs for Split.configuration.cache

  rdh

  committed
  a26b595

  Copy full SHA for a26b595

Commits on Dec 7, 2020

• Merge pull request splitrb#648 from yankaindustries/master

  Show description for 35b5259
  andrehjr

  authored
  35b5259

  Copy full SHA for 35b5259

• Centralize checks for experiment existance in experiment catalog

  andrehjr

  committed
  3e9c1ae

  Copy full SHA for 3e9c1ae

• Add note for caching only being available on v4.0+

  andrehjr

  committed
  5ea585c

  Copy full SHA for 5ea585c

• Set main branch as 4.0.0.pre

  andrehjr

  committed
  deaa469

  Copy full SHA for deaa469

• Merge pull request splitrb#651 from splitrb/check-if-experiment-is-new-by-catalog

  Show description for 429614e
  andrehjr

  authored
  429614e

  Copy full SHA for 429614e

Commits on Dec 9, 2020

• Cherry pick the second split cache optimization

  amangup

  committed
  310cfc6

  Copy full SHA for 310cfc6

• Deleting an extra line

  amangup

  committed
  b611d6c

  Copy full SHA for b611d6c

• Removing the comment which says reboot required for new experiment config to take effect

  amangup

  committed
  73ef502

  Copy full SHA for 73ef502

Commits on Dec 13, 2020

• Merge pull request splitrb#652 from yankaindustries/cache_experiment_save_path

  Show description for 24e748c
  andrehjr

  authored
  24e748c

  Copy full SHA for 24e748c

Commits on Dec 17, 2020

• Update changelog

  andrehjr

  committed
  94f297f

  Copy full SHA for 94f297f

• Reference 4.0.0.pre on CHANGELOG

  andrehjr

  committed
  c4ed88c

  Copy full SHA for c4ed88c

Commits on Mar 27, 2021

• Add missing entry to the changelog

  andrehjr

  committed
  74266e8

  Copy full SHA for 74266e8

Commits on Apr 27, 2021

• Fix minor typos in README.md

  iridakos

  authored
  b8e7838

  Copy full SHA for b8e7838

Commits on Apr 29, 2021

• Upgrade to GitHub-native Dependabot

  dependabot-preview[bot]

  authored
  4dfb5da

  Copy full SHA for 4dfb5da

Commits on May 3, 2021

• Merge pull request splitrb#656 from iridakos/main

  Show description for f4c5685
  andrehjr

  authored
  f4c5685

  Copy full SHA for f4c5685

Commits on May 6, 2021

• Merge pull request splitrb#657 from splitrb/dependabot/add-v2-config-file

  Show description for b150edb
  andrehjr

  authored
  b150edb

  Copy full SHA for b150edb

Commits on May 19, 2021

• Uset Redis#hmset to keep compatibility with Redis < 4.0

  andrehjr

  committed
  cc7c41b

  Copy full SHA for cc7c41b

• Merge pull request splitrb#659 from splitrb/keep-redis-compat-hset

  Show description for a93aedf
  andrehjr

  authored
  a93aedf

  Copy full SHA for a93aedf

Commits on Jul 14, 2021

• Fix cleanup_old_versions! misbehaviour

  serggl

  committed
  4b6c5c0

  Copy full SHA for 4b6c5c0

Commits on Jul 18, 2021

• Add initial workflow

  andrehjr

  committed
  92c60b4

  Copy full SHA for 92c60b4

• Remove travis.yml

  andrehjr

  committed
  c9a51fb

  Copy full SHA for c9a51fb

• Merge pull request splitrb#662 from splitrb/gh-actions

  Show description for df48f1a
  andrehjr

  authored
  df48f1a

  Copy full SHA for df48f1a

• Update README.md

  andrehjr

  authored
  d549a5e

  Copy full SHA for d549a5e

Commits on Jul 19, 2021

• fix spec failures

  serggl

  committed
  2037c4a

  Copy full SHA for 2037c4a

• Merge pull request splitrb#661 from serggl/cleanup_old_versions

  Show description for b941a9e
  andrehjr

  authored
  b941a9e

  Copy full SHA for b941a9e

Commits on Aug 13, 2021

• Adds config option for cookie domain

  joedelia

  committed
  dfaa05b

  Copy full SHA for dfaa05b

• Removes domain option if set to nil

  joedelia

  committed
  dca0d24

  Copy full SHA for dca0d24

Commits on Aug 21, 2021

• Merge pull request splitrb#664 from joedelia/feature/set-cookie-domain

  Show description for 36495a5
  andrehjr

  authored
  36495a5

  Copy full SHA for 36495a5

Commits on Aug 25, 2021

• Update RSpec helper to support block syntax

  Show description for b65e5b2
  clowder

  authored
  b65e5b2

  Copy full SHA for b65e5b2

Commits on Sep 23, 2021

• Keep railtie defined under the Split gem namespace

  avit

  committed
  047b621

  Copy full SHA for 047b621

Commits on Sep 25, 2021

• Merge pull request splitrb#666 from avit/split-namespace

  Show description for 1cc4f2f
  andrehjr

  authored
  1cc4f2f

  Copy full SHA for 1cc4f2f

Commits on Nov 7, 2021

• Simply check for the experiment name without the version

  andrehjr

  committed
  d6e9610

  Copy full SHA for d6e9610

• Merge pull request splitrb#670 from splitrb/improve-checking-for-old-versions

  Show description for 8e4f7f8
  andrehjr

  authored
  8e4f7f8

  Copy full SHA for 8e4f7f8

• Merge pull request splitrb#665 from clowder/patch-1

  Show description for 7872301
  andrehjr

  authored
  7872301

  Copy full SHA for 7872301

• 4.0.0.pre2

  andrehjr

  committed
  f88bb07

  Copy full SHA for f88bb07

Commits on Dec 26, 2021

• Add newer versions of Rails and Ruby to be tested on CI

  andrehjr

  committed
  09eed00

  Copy full SHA for 09eed00

• Need to fix a few things before pushing ruby 3.1

  andrehjr

  committed
  fbb9b73

  Copy full SHA for fbb9b73

• Merge pull request splitrb#671 from splitrb/add-newer-rails-and-ruby-to-ci

  Show description for d0c3340
  andrehjr

  authored
  d0c3340

  Copy full SHA for d0c3340

Commits on Dec 30, 2021

• v4.0.0

  andrehjr

  committed
  6f95d35

  Copy full SHA for 6f95d35

• v4.0.1

  andrehjr

  committed
  c1b198f

  Copy full SHA for c1b198f

Commits on Feb 11, 2022

• Add ability to initialize experiments

  robin-phung

  committed
  080c0ea

  Copy full SHA for 080c0ea

Commits on Mar 4, 2022

• Update Ruby and Rails requirements on README

  andrehjr

  committed
  da3d77c

  Copy full SHA for da3d77c

• Remove unused Gemfiles from tests

  andrehjr

  committed
  c686794

  Copy full SHA for c686794

• Encapsulate Split::Algorithms at our own module to avoid explicit calling rubystats everywhere

  andrehjr

  committed
  d109915

  Copy full SHA for d109915

• Require matrix to be installed in order to make it compatible with Ruby 3.1+

  andrehjr

  committed
  1faca22

  Copy full SHA for 1faca22

• Merge pull request splitrb#674 from splitrb/encapsulate_ruby_stats

  Show description for 0474494
  andrehjr

  authored
  0474494

  Copy full SHA for 0474494

• Add Ruby 3.1 to the matrix

  andrehjr

  committed
  c54ed80

  Copy full SHA for c54ed80

• Add matrix to Rails 7.0 gemfile

  andrehjr

  committed
  6280af1

  Copy full SHA for 6280af1

• Merge pull request splitrb#675 from splitrb/enable-rb-31

  Show description for d97483e
  andrehjr

  authored
  d97483e

  Copy full SHA for d97483e

• Remove appraisals

  andrehjr

  committed
  a47651c

  Copy full SHA for a47651c

• Merge pull request splitrb#676 from splitrb/cleanup-appraisals

  Show description for c4a3e22
  andrehjr

  authored
  c4a3e22

  Copy full SHA for c4a3e22

• Remove usage of deprecated implicit block expectation from specs

  andrehjr

  committed
  49bf6c2

  Copy full SHA for 49bf6c2

• Merge pull request splitrb#677 from splitrb/fix-spec-deprecations

  Show description for a663a33
  andrehjr

  authored
  a663a33

  Copy full SHA for a663a33

• Fix rubocop Layout issues

  andrehjr

  committed
  c02d1c1

  Copy full SHA for c02d1c1

• Fix Style/HashSyntax offenses

  andrehjr

  committed
  accf157

  Copy full SHA for accf157

• Merge pull request splitrb#678 from splitrb/fix-hash-syntax-offenses

  Show description for 3f4105a
  andrehjr

  authored
  3f4105a

  Copy full SHA for 3f4105a

• Fix Layout/EmptyLinesAroundAccessModifier

  andrehjr

  committed
  88d600e

  Copy full SHA for 88d600e

• Fix Layout/EmptyLinesAroundClassBody

  andrehjr

  committed
  41b3126

  Copy full SHA for 41b3126

• Fix Layout/CommentIndentation

  andrehjr

  committed
  92dc8ed

  Copy full SHA for 92dc8ed

• Fix Layout/ElseAlignment

  andrehjr

  committed
  6d89af5

  Copy full SHA for 6d89af5

• Fix Layout/EmptyLinesAroundMethodBody

  andrehjr

  committed
  f4de6d9

  Copy full SHA for f4de6d9

• Fix Layout/EmptyLinesAroundModuleBody

  andrehjr

  committed
  91ba5ce

  Copy full SHA for 91ba5ce

• Fix Layout/EndAlignment

  andrehjr

  committed
  4d8b5a9

  Copy full SHA for 4d8b5a9

• Fix Layout/SpaceAroundEqualsInParameterDefault

  andrehjr

  committed
  c0b1af4

  Copy full SHA for c0b1af4

• Fix Layout/SpaceBeforeBlockBraces

  andrehjr

  committed
  f51598d

  Copy full SHA for f51598d

• Fix Layout/SpaceInsideBlockBraces

  andrehjr

  committed
  b2562db

  Copy full SHA for b2562db

• Fix Layout/SpaceInsideHashLiteralBraces

  andrehjr

  committed
  baba207

  Copy full SHA for baba207

• Fix Layout/TrailingEmptyLines

  andrehjr

  committed
  96ab0c0

  Copy full SHA for 96ab0c0

• Fix Layout/TrailingWhitespace

  andrehjr

  committed
  67d57b1

  Copy full SHA for 67d57b1

• Fix Layout/IndentationWidth

  andrehjr

  committed
  003c098

  Copy full SHA for 003c098

• Fix Lint/UselessAssignment

  andrehjr

  committed
  3ed07e3

  Copy full SHA for 3ed07e3

• Add missing frozen_string_literal: true

  andrehjr

  committed
  22954b9

  Copy full SHA for 22954b9

• Enable rubocop for specs too

  andrehjr

  committed
  ac81c9c

  Copy full SHA for ac81c9c

• Merge pull request splitrb#673 from robin-phung/add-unregistered-experiment

  Show description for e5077d3
  andrehjr

  authored
  e5077d3

  Copy full SHA for e5077d3

• Merge pull request splitrb#679 from splitrb/fix-layout-offenses

  Show description for 1ebd423
  andrehjr

  authored
  1ebd423

  Copy full SHA for 1ebd423

• Enable Rubocop to be executed at CI

  andrehjr

  committed
  b7bf52a

  Copy full SHA for b7bf52a

• Fix remaining rubocop offenses

  andrehjr

  committed
  ec3a9b7

  Copy full SHA for ec3a9b7

• Merge pull request splitrb#680 from splitrb/enable-rubocop-ci

  Show description for 8a16b49
  andrehjr

  authored
  8a16b49

  Copy full SHA for 8a16b49

• Fix Style/AndOr

  andrehjr

  committed
  d108971

  Copy full SHA for d108971

• Fix Style/ColonMethodCall

  andrehjr

  committed
  bd0e161

  Copy full SHA for bd0e161

• Fix Style/DefWithParentheses

  andrehjr

  committed
  f723890

  Copy full SHA for f723890

• Fix Style/MethodDefParentheses

  andrehjr

  committed
  dcc87ec

  Copy full SHA for dcc87ec

• Fix Style/RedundantReturn

  andrehjr

  committed
  8dc7727

  Copy full SHA for 8dc7727

• Merge pull request splitrb#681 from splitrb/fix-rubocop-offenses

  Show description for c49f156
  andrehjr

  authored
  c49f156

  Copy full SHA for c49f156

• Enforce double quotes

  andrehjr

  committed
  9c2f237

  Copy full SHA for 9c2f237

Commits on Mar 7, 2022

• Merge pull request splitrb#682 from splitrb/fix-string-literals

  Show description for 4ee3f02
  andrehjr

  authored
  4ee3f02

  Copy full SHA for 4ee3f02

Commits on Apr 2, 2022

• Update actions/checkout to v3

  andrehjr

  committed
  6f9f8c7

  Copy full SHA for 6f9f8c7

• Merge pull request splitrb#683 from splitrb/update-actions-checkout-v3

  Show description for 9a0e280
  andrehjr

  authored
  9a0e280

  Copy full SHA for 9a0e280

Commits on Apr 19, 2022

• Merge branch 'main' of https://github.com/splitrb/split into splitrb-main

  robin-phung

  committed
  829b5e1

  Copy full SHA for 829b5e1

Commits on Apr 20, 2022

• Fix spec merging

  robin-phung

  committed
  7e58af4

  Copy full SHA for 7e58af4

Commits on Apr 21, 2022

• remove reintroduced no longer used func

  robin-phung

  committed
  9a0104e

  Copy full SHA for 9a0104e