-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MQTT-support #766
base: main
Are you sure you want to change the base?
MQTT-support #766
Conversation
cb77ee8
to
7130ee3
Compare
I think you can (and maybe even should) build clean session by reusing the auto delete feature of queues. |
787840d
to
4e747f2
Compare
About #803 (comment) That connect spec passes, but for the wrong reason. Or well, the socket is closed but not because it receives the wrong packet type, but because of the bug that #803 will fix. When that bug is fixed i still think that the spec will pass, but for the right reason. I guess the spec could be changed to send a |
After giving it a second thought I've concluded that we should change the spec to use some other packet type. |
ok I will change the spec then! thanks :) |
Often it's more efficient to |
* deliver packet not msg from session * it's already a topic, no convert needed * fixes
WHAT is this pull request doing?
An MQTT-session inherits AMQP::Queue and extends with MQTT functionality.
MQTT exchange(topic) will only accept activity from an MQTT client, that will be responsible for routing messages to the MQTT-session.
The mqtt exchange handles MQTT routing keys etc. without needing to do conversions.
If we want an AMQP client send messages to an MQTT session, or vice versa, we can do an exchange to exchange binding and do conversions then.
HOW can this pull request be tested?
Specs have been migrated from Myra and fully cover the MQTT protocol, run with crystal spec.