Adds lag_in_actions to metrics #811
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kickster97
approved these changes
Oct 24, 2024
viktorerlingsson
force-pushed
the
lag_in_actions
branch
from
94e36c3
to
ec0f1af
Compare
|
But it's not the whole story, right? Actions could still be in the tcp send buffer, or being processed at the follower. |
Hmm, yeah that's true. And I guess there's no good way for us to know how many actions are there. 🤔 |
snichme
reviewed
Oct 29, 2024
| @@ -177,6 +177,7 @@ module LavinMQ | |||
| sent_bytes: @sent_bytes, | |||
| acked_bytes: @acked_bytes, | |||
| lag_in_bytes: lag_in_bytes, | |||
| lag_in_actions: lag_in_actions, | |||
There was a problem hiding this comment.
We talked about calling it clustering_actions_queue_size instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Adds number of unsynced actions as
lag_in_actionsto metrics, by checking the size of the@actionschannel's internal Dequeue.HOW can this pull request be tested?
Manual