removed extra metrics table

cloudamqp · Dec 1, 2023 · 8611635 · 8611635
1 parent 8861a7a
commit 8611635
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/deps/rabbitmq_stream/include/rabbit_stream_metrics.hrl b/deps/rabbitmq_stream/include/rabbit_stream_metrics.hrl
@@ -2,7 +2,6 @@
 
 -define(TABLE_CONSUMER, rabbit_stream_consumer_created).
 -define(TABLE_PUBLISHER, rabbit_stream_publisher_created).
--define(TABLE_CONSUMER_METRIC, stream_consumer_metrics).
 
 -define(STREAM_DOES_NOT_EXIST, ?NUM_PROTOCOL_COUNTERS + 1).
 -define(SUBSCRIPTION_ID_ALREADY_EXISTS, ?NUM_PROTOCOL_COUNTERS + 2).

diff --git a/deps/rabbitmq_stream/src/rabbit_stream_metrics.erl b/deps/rabbitmq_stream/src/rabbit_stream_metrics.erl
@@ -31,8 +31,7 @@
 
 init() ->
     _ = rabbit_core_metrics:create_table({?TABLE_CONSUMER, set}),
-    _ = rabbit_core_metrics:create_table({?TABLE_PUBLISHER, set}),
-    _ = rabbit_core_metrics:create_table({?TABLE_CONSUMER_METRIC, set}),
+    _ = rabbit_core_metrics:create_table({?TABLE_PUBLISHER, set})
     ok.
 
 consumer_created(Connection,
@@ -55,8 +54,6 @@ consumer_created(Connection,
          {properties, Properties}],
     ets:insert(?TABLE_CONSUMER,
                {{StreamResource, Connection, SubscriptionId}, Values}),
-    ets:insert(?TABLE_CONSUMER_METRIC,
-               {Connection, Values}),
     rabbit_global_counters:consumer_created(stream),
     rabbit_core_metrics:consumer_created(Connection,
                                          consumer_tag(SubscriptionId),
@@ -94,8 +91,6 @@ consumer_updated(Connection,
          {properties, Properties}],
     ets:insert(?TABLE_CONSUMER,
                {{StreamResource, Connection, SubscriptionId}, Values}),
-    ets:insert(?TABLE_CONSUMER_METRIC,
-               {Connection, Values}),
     rabbit_core_metrics:consumer_updated(Connection,
                                          consumer_tag(SubscriptionId),
                                          false,
@@ -112,8 +107,6 @@ consumer_updated(Connection,
 consumer_cancelled(Connection, StreamResource, SubscriptionId) ->
     ets:delete(?TABLE_CONSUMER,
                {StreamResource, Connection, SubscriptionId}),
-    ets:delete(?TABLE_CONSUMER_METRIC,
-               {{Connection}}),
     rabbit_global_counters:consumer_deleted(stream),
     rabbit_core_metrics:consumer_deleted(Connection,
                                          consumer_tag(SubscriptionId),