Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: works with TBC Classic 2.5.4, missing TomTom/location stuff #19

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

mhco
Copy link

@mhco mhco commented Apr 10, 2022

Big TBC Classic Compatibility Update

Features:

  • TBC Classic Spells for every class and pets
  • Professions
  • Code completely redone to allow future-proofing (smooth transition when WotLK comes out)
  • Item links are now possible. Link to items or spells, depending on which you want to display on any given screen

Warning: TomTom and Location features are removed from this version temporarily

I stripped out the TomTom and location stuff in order to get this working with TBC. These features are not incompatible with my version of the addon, but I removed them to simplify the addon while I was working on it. My main goal was to get the spells working, so I got rid of code that didn't matter so I could focus on what did. TomTom and trainer location features can be easily re-added to the addon, but users should be aware that they aren't currently there.

To do:

  • Verify this change doesn't reintroduce bugs from previous issues (it shouldn't, but I want to be 100% sure):
    • 17
    • 11
    • 8
    • 5
    • 4
    • 3
    • 1
  • Add TomTom/trainer location functionality back in
  • Add more data to professions, such as:
    • Which fish you can fish at a given level
    • Which herbs you can gather at a given level

@mhco
Copy link
Author

mhco commented Apr 10, 2022

I'm currently working on adding the rest of the professions to the addon, but I figured that can be worked on before the next release, but after the initial changes are merged. I'll need help with adding fish levels, herbs, etc., to speed things up.

@mhco
Copy link
Author

mhco commented Apr 11, 2022

It should be noted that this pull closes issues #18, #15, #14, #10, and #12 (I have personally confirmed all of these tickets are fixed).

@cloudbells
Copy link
Owner

Hey! This is obviously a ton of work and I'm a little humbled someone would take the time to make this addon work again.

I could not find a way to contact you, could you send me an email (address is on my profile) before I go through this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants