-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update broken Zone entry struct #240
Update broken Zone entry struct #240
Conversation
…x owner field for zone details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cloudflare can we get this merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes issue. Recommend merge. @jeff-hiner Could you help with this?
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I encountered the issue described in #236, I tested this PR and it fixed the issue, thanks for the fix!
Sorry for the delay on this. Approving this. Please @ me in the future |
Does the following:
multiple_railguns_allowed
field, as it appears to be removed. Fixesmultiple_railguns_allowed
is gone from the Zone entry #236owner
field optional (zone: make Owner fields optional #232), as otherwise the examples would still not workactivated_on
fieldThere are some more discrepancies, i.e. fields on the docs that don't exist here, and fields here that don't exist in the docs, but I want to refrain from changing too much.
This can be tested with the
cloudflare-examples
cli:Before
After