Add RetryFileWriter to handle BrokenPipe errors #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors are recoverable if the pipe still exists and the reader may come back at some point.
Remove nanoid Remove fifo check, it doesn't fit our use case
kornelski
reviewed
Jan 29, 2025
| /// where actually processed by the read side. | ||
| pub(crate) struct RetryPipeWriter { | ||
| path: PathBuf, | ||
| pipe_file: Box<File>, |
There was a problem hiding this comment.
File is a 4-byte integer, so you don't need to Box it.
kornelski
approved these changes
Jan 29, 2025
aberglund-cf
force-pushed
the
add_retry_writer_for_pipes
branch
from
1624829 to
9f37087
Compare
fisherdarling
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors are recoverable if the pipe still exists and the reader may come back at some point.