Fix autogenerated append to original _headers file #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vercel hard links the public directory so when next-on-pages appends to the vercel output directory, it is also appending to the original `public/_headers` file too. This commit fixes the problem by copying the contents to memory before unlinking the file and creating a new (non-linked) file. I was able to test out this patch and saw it worked for when `_headers` exists and when it is absent. Closes cloudflare#848
🦋 Changeset detectedLatest commit: b7ee058 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🧪 Prereleases are available for testing 🧪 @cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/10282660127/npm-package-next-on-pages-851@cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/10282660127/npm-package-eslint-plugin-next-on-pages-851 |
packages/next-on-pages/src/buildApplication/buildMetadataFiles.ts
Outdated
Show resolved
Hide resolved
dario-piotrowicz
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Looks great to me! Thanks a bunch @nickbabcock 🙂 ❤️
I've just left a minor comment, also could you run npm run prettier:fix to format the code? 🙂🙏
|
Comments addressed, thank you 🙏 |
dario-piotrowicz
approved these changes
Aug 7, 2024
packages/next-on-pages/src/buildApplication/buildMetadataFiles.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Dario Piotrowicz <[email protected]>
|
Once again thanks a lot @nickbabcock 🫶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vercel hard links the public directory so when next-on-pages appends to file within the vercel output directory, it is also appending to the original
public/_headersfile too.This commit fixes the problem by copying the contents to memory before unlinking the file and creating a new (non-linked) file.
I was able to test out this patch and saw it worked for when
_headersexists and when it is absent.Closes #848