Sync Feb 21 #531
Merged
Sync Feb 21 #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcaramelsyrup
approved these changes
Feb 21, 2025
Older HTTP versions don't really support it.
Adjusts the pingora-header-serde internals to use a preloaded zstd dictionary when one is specified. Previously the thread_zstd mod used `(de)compress_using_dict` zstd safe calls, which are part of the "simple" zstd API and would load the dictionary on every operation, adding non-trivial CPU cost. This change instead changes the compression APIs to use dictionaries through the "bulk processing" APIs which accept preloaded `CDict` and `DDict`s, at the cost of needing to specify the compression level in advance.
eaufavor
force-pushed
the
bleeper-yuchen-595e312ee6
branch
from
9f5a24c to
a9735ba
Compare
Noah-Kennedy
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.