h3: prevent multiple calls to send_response | send_response_with_priority #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rity We recently added the `send_additional_headers()` method to support sending mupltiple HEADERS for a single request or response. However, it remained possible to call `send_response()` or `send_response_with_priority()` multiple times for the same stream ID, which is now unintuitive. This change enforces that `send_response()` or `send_response_with_priority()` can only be called once per stream.
ghedo
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added the
send_additional_headers()method to support sendingmupltiple HEADERS for a single request or response. However, it remained
possible to call
send_response()orsend_response_with_priority()multiple times for the same stream ID, which is now unintuitive.
This change enforces that
send_response()orsend_response_with_priority()can only be called once per stream.