Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable built-in compile cache behind autogate #3107

Merged
merged 1 commit into from
Nov 15, 2024
Merged

enable built-in compile cache behind autogate #3107

merged 1 commit into from
Nov 15, 2024
+51 −37

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 13, 2024

Enables compile cache behind an autogate flag.

@anonrig anonrig requested review from a team as code owners November 13, 2024 20:22
jasnell
jasnell reviewed Nov 13, 2024
View reviewed changes
src/workerd/jsg/modules.c++ Outdated Show resolved Hide resolved
src/workerd/jsg/modules.c++ Outdated Show resolved Hide resolved
@anonrig anonrig force-pushed the yagiz/enable-compile-cache branch 2 times, most recently from 2c0ec7f to 8b8fa5b Compare November 13, 2024 20:32
mikea
mikea approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@mikea mikea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell stole some of my comments. otherwise lg.

src/workerd/server/workerd-api.c++ Outdated Show resolved Hide resolved
@anonrig anonrig force-pushed the yagiz/enable-compile-cache branch 2 times, most recently from a8be30e to 54c590f Compare November 13, 2024 21:03
@anonrig
Copy link
Member Author

anonrig commented Nov 13, 2024

I believe this is ready to land @jasnell @mikea. Appreciate if you could take one more look before landing this. PS: @kentonv would you mind taking a look as well?

danlapid
danlapid approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@danlapid danlapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anonrig anonrig force-pushed the yagiz/enable-compile-cache branch 4 times, most recently from 35fe2e2 to c1f1578 Compare November 15, 2024 17:01
@anonrig anonrig merged commit 4c06013 into main Nov 15, 2024
14 checks passed
@anonrig anonrig deleted the yagiz/enable-compile-cache branch November 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlapid danlapid danlapid approved these changes

@jasnell jasnell jasnell approved these changes

@kentonv kentonv Awaiting requested review from kentonv

@mikea mikea Awaiting requested review from mikea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anonrig @mikea @jasnell @danlapid