test: add test for loadbalancing route option #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffmaen
force-pushed
the
maxmoehl/add-route-options
branch
from
9e76848 to
2474f7a
Compare
Co-Authored-By: Clemens Hoffmann <[email protected]>
maxmoehl
force-pushed
the
maxmoehl/add-route-options
branch
from
2b9cfcf to
1bbf1e8
Compare
maxmoehl
changed the title
ctlong
requested changes
Feb 20, 2025
|
Those things are mostly leftovers from our testing to figure out what was wrong. I'll clean them up. |
|
Once we are happy with the code we can have another test run to ensure everything still works properly. @ctlong please have another look. |
maxmoehl
force-pushed
the
maxmoehl/add-route-options
branch
from
d84ab98 to
d95d949
Compare
ctlong
requested changes
Feb 27, 2025
ctlong
previously approved these changes
Mar 1, 2025
|
Thanks! @iaftab-alam ran the tests again and they pass so this is good to merge from our side. |
|
LGTM! Can you please record how many minutes this will increase CATs runs? You can do this by comparing the previous runtime of the routing test suite with the runtime of the new routing test suite, using around 12 parallel nodes. And can you also list the CF-D version that you ran this against? Actually... does this require some minimum CF-D/CAPI version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
All PR's to CATs should be submitted to develop and will be merged to main once they've passed acceptance.
What is this change about?
Add an acceptance test for per-route options as described in #1352.
Please provide contextual information.
#1352, cloudfoundry/community#909
What version of cf-deployment have you run this cf-acceptance-test change against?
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
It tests the E2E functionality of per-route options. Each component has its own acceptance tests but we want to ensure that the E2E scenario works with every released cf-d.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
Unknown
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!