Implement /api/v1/read for GAUGE envelopes #3769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danail-branekov
previously approved these changes
Jan 30, 2025
* Allow `GAUGE` envelope type for the `envelope_type` query parameters * The implementation assumes `LOGS` envelope type if not specified. This is good enough for the current implementation and we do not have to merge logs and gauges. We could change that in future if needed * When the envelope type is `GAUGE` we ignore all the other query paramters as we do not return historical data, i.e. all the gauge values represent the current state. Co-authored-by: Georgi Sabev <[email protected]> Co-authored-by: Yusmen Zabanov <[email protected]> Co-authored-by: Danail Branekov <[email protected]> fixes #3752 Co-authored-by: Georgi Sabev <[email protected]> Co-authored-by: Yusmen Zabanov <[email protected]>
danail-branekov
force-pushed
the
issues/3752-logcache-gauge
branch
from
9f0c38d to
1ce6b71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3752
What is this change about?
GAUGEenvelope type for theenvelope_typequery parametersLOGSenvelope type if not specified. Thisis good enough for the current implementation and we do not have to
merge logs and gauges. We could change that in future if needed
GAUGEwe ignore all the other queryparamters as we do not return historical data, i.e. all the gauge
values represent the current state.
Tag your pair, your PM, and/or team
@georgethebeatle