Adding instructions to README.md and configuring prophet utils unit test #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instructions-and-configuring-prophet-utils-unit-test
…t-utils-unit-test
…t-utils-unit-test
…test' of https://github.com/cloudhubs/prophet-utils into Adding-instructions-and-configuring-prophet-utils-unit-test
|
Please target https://github.com/cloudhubs/prophet-utils/tree/graalvm-extensions branch instead of master. We will keep the modified version there for now. By targeting master, this PR shows a much bigger diff in terms of changed files than it should. |
|
Also please make sure there are no unnecessary merge commits in the history. Which branch did you start from? Seems to be a master branch? Maybe it will be faster to make a new branch from /graalvm-extensions and then cherry pick your changes there, so that the commit history is not polluted. If you are not sure how to do it, we can discuss that during our meeting tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.