feat(cluster): add ldap configuration and documentation #509
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pha91
force-pushed
the
feature/add-ldap-configuration
branch
4 times, most recently
from
ba61737 to
bd32cfc
Compare
Signed-off-by: pha91 <[email protected]>
pha91
force-pushed
the
feature/add-ldap-configuration
branch
from
bd32cfc to
88c60be
Compare
|
Hi @itay-grudev, Many thanks |
|
I'll prioritise it. There is already one other PR for LDAP #409, but it didn't have tests unlike yours, which makes my life easier. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to set the LDAP Configuration which is documented here
Same as in #409 without the merged service config feature.