Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use actions/upload-artifact@v4 in workflows #62

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

avinashbot
Copy link
Member

@avinashbot avinashbot commented Feb 3, 2025

Description

actions/upload-artifact@v3 literally doesn't work anymore :)

Removed the duplicate artifact stuff cause it's a nice-to-have and it needs a little bit of investigation before merging.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (1055d7b) to head (2e0d85d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #62      +/-   ##
===========================================
- Coverage   100.00%   99.20%   -0.80%     
===========================================
  Files           27       28       +1     
  Lines          384      251     -133     
  Branches        30       30              
===========================================
- Hits           384      249     -135     
- Misses           0        1       +1     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avinashbot avinashbot force-pushed the fix-visual-regression-tests branch from 0322fbf to 2e0d85d Compare February 20, 2025 13:57
@avinashbot avinashbot marked this pull request as ready for review February 20, 2025 13:57
@avinashbot avinashbot requested a review from a team as a code owner February 20, 2025 13:57
@avinashbot avinashbot requested review from cansuaa and removed request for a team February 20, 2025 13:57
@avinashbot avinashbot added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit fa8682c Feb 20, 2025
38 of 39 checks passed
@avinashbot avinashbot deleted the fix-visual-regression-tests branch February 20, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants