Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds pseudo element around the annotation trigger #3241

Closed
wants to merge 1 commit into from

Conversation

orangevolon
Copy link
Contributor

@orangevolon orangevolon commented Jan 31, 2025

Description

Extends the clickable area of the hotspot button to 24 pixels. This is to conform to WCAG 2.2 specs.

Related links, issue #, if available: AWSUI-60217

A more complicated solution with many more moving parts is also available in #3237. Feel free to compare the both solutions but we are leaning toward this solution which is simpler.

How has this been tested?

Dev pipeline screenshot tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (c1a6f63) to head (96cd64f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3241      +/-   ##
==========================================
+ Coverage   96.45%   96.53%   +0.07%     
==========================================
  Files         790      792       +2     
  Lines       22294    23117     +823     
  Branches     7667     7669       +2     
==========================================
+ Hits        21504    22315     +811     
- Misses        738      795      +57     
+ Partials       52        7      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orangevolon orangevolon marked this pull request as ready for review February 3, 2025 12:41
@orangevolon orangevolon requested a review from a team as a code owner February 3, 2025 12:41
@orangevolon orangevolon requested review from connorlanigan and removed request for a team February 3, 2025 12:41
@orangevolon
Copy link
Contributor Author

PR created from wrong branch. Replaced with #3246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant