Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add labels for folder/object icons in S3 resource selector #3248

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

avinashbot
Copy link
Member

@avinashbot avinashbot commented Feb 4, 2025

Waiting for translations to come back. Will merge them separately before rebasing this branch and adding support for them.

Description

These meaningful icons in the S3 resource selector aren't labelled. Whoops. So this PR adds labelIconFile and labelIconFolder properties to the component's I18nStrings interface.

Screenshot 2025-02-04 at 17 59 20

Related links, issue #, if available: AWSUI-60208

How has this been tested?

Unit tests.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot force-pushed the s3-resource-selector-icon branch from c56b7b3 to 3615250 Compare February 4, 2025 17:04
@avinashbot avinashbot changed the title feat: Add aria labels for folder/file icons in S3 resource selector feat: Add labels for folder/file icons in S3 resource selector Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (f8a00dd) to head (c7c9405).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3248    +/-   ##
========================================
  Coverage   96.44%   96.44%            
========================================
  Files         791      791            
  Lines       22568    22569     +1     
  Branches     7385     7802   +417     
========================================
+ Hits        21765    21766     +1     
+ Misses        796      750    -46     
- Partials        7       53    +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avinashbot avinashbot force-pushed the s3-resource-selector-icon branch from 3615250 to af79466 Compare February 5, 2025 15:39
@avinashbot avinashbot changed the title feat: Add labels for folder/file icons in S3 resource selector feat: Add labels for folder/object icons in S3 resource selector Feb 5, 2025
@avinashbot avinashbot force-pushed the s3-resource-selector-icon branch 2 times, most recently from 9c34937 to fc2be0a Compare February 5, 2025 15:43
@avinashbot avinashbot force-pushed the s3-resource-selector-icon branch from a1585f1 to c7c9405 Compare February 7, 2025 14:22
@avinashbot avinashbot marked this pull request as ready for review February 7, 2025 14:24
@avinashbot avinashbot requested a review from a team as a code owner February 7, 2025 14:24
@avinashbot avinashbot requested review from at-susie and removed request for a team February 7, 2025 14:24
@avinashbot avinashbot requested review from a team and jperals and removed request for at-susie and a team February 7, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant