chore: Updates integ tests for compatibility with webdriver upgrade #154
Conversation
pan-kot
force-pushed
the
chore-webdriver8-1
branch
from
b0221cd to
7da1137
Compare
pan-kot
force-pushed
the
chore-webdriver8-1
branch
from
7da1137 to
0f3fab0
Compare
| @@ -93,6 +96,8 @@ describe('S3 Resource Selector - Read mode', () => { | |||
| 'shows alert about missing versions', | |||
| setupTest(async page => { | |||
| await page.setUriInputValue('s3://bucket-officia/particle-1ns.sim'); | |||
| // click somewhere to blur the input and trigger validation | |||
| await page.click(createWrapper().findHeader().toSelector()); | |||
There was a problem hiding this comment.
Now that we're copying the same comment and the statement it in multiple places, how about just making a function out of it?
async function waitForValidation() {
// click somewhere to blur the input and trigger validation
await page.click(createWrapper().findHeader().toSelector());
}There was a problem hiding this comment.
That click to the header is only needed to trigger a blue on the input for the validation to appear. It can as well be a click on another element or pressing Tab. The comment is needed to explain that it is not the click itself that matters but the blur. I am hesitating to create a function for it because: 1) it is hard to come up with a clear enough name, the "wait for validation" is not correct; 2) it makes an assumption that the header exists which might not be true for some new page if we want to reuse the function in there.
There was a problem hiding this comment.
If we can come up with a proper name for the function, the name of the function could be a very good replacement for the comment that we have repeated several times. That being said, if it's not applicable in this context then let's go with the comment 👍
Preparing for changes to browser test tools: cloudscape-design/browser-test-tools#107
Rel: CR-148624506
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.