fix: Chat test dry run - Add VR class to the html #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-kot
previously approved these changes
Jan 16, 2025
just-boris
reviewed
Jan 16, 2025
| @@ -42,7 +42,7 @@ function createHtml({ title, headImports, bodyImports, bodyContent }) { | |||
| <link href="vendor.css" rel="stylesheet"> | |||
| ${headImports} | |||
| </head> | |||
| <body id="b"> | |||
| <body id="b" class="awsui-visual-refresh"> | |||
There was a problem hiding this comment.
This is "demos" package, an example how to use our components.
But the actual usage of our @cloudscape-design/components package does not need this class, so this is misleading.
Because it is a temporary workaround, setting it is fine, but let's leave a comment that it is not needed in real use-cases
There was a problem hiding this comment.
Also, we need to invite @michaeldowseza to discuss a long term solution here
pan-kot
approved these changes
Jan 16, 2025
just-boris
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: AWSUI-60272
Description of changes: The chat test in dry run was failing because classic components were being used, adding the VR classname so the tests run with VR components instead. The test is now passing in this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.