feat!: allow specify instance count - breaking change #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlo03
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking change
The previous terraform configuration allowed users to update the max_instance_count of each function in the console and have terraform ignore the change. This change puts max_instance_count under terraform control and is therefore a breaking change for users who were relying on terraform never updating the value they set. It does not seem possible to ignore_changes selectively (EG if the max_instance_count var was null).
The default of null (which then defaults to 100 in Cloud Run) remains unchanged.
Partially address #440
BEFORE
AFTER