SSC: Remove Boss-Requirements from Vashj (2.4.0)

[insunaa]

🍰 Pullrequest

This PR removes the requirement to kill all bosses in SSC prior to attempting Lady Vashj, as per Patchnotes of 2.4.0

Proof

• Patch 2.4.0

How2Test

• Go to Lady Vashj's bridge console. Click on it immediately

Todo / Checklist

• Maybe gate the "removal" behind PRENERF macro, to ensure both types of behaviour can be observed if desired.

[killerwife]

PRENERF_2_3

[insunaa]

Yeah, I know. I'll probably rework it as I said in ToDo

[cpevors]

Can confirm -- I have tested both the 2.4 and pre-2.4 behaviour. This commit seems to accomplish both, and the raid instance is working as intended.

[insunaa]

Actually having just tested the bug report I couldn't actually reproduce it even without these fixes applied. Everything just worked. Some more investigation is needed, I'll return this to a draft PR.

Edit: It seems this commit added these flags that shouldn't be there: cmangos/tbc-db@b6797db#diff-cd31318aa943f6fee873d89faf5767814629694f399bc33627931c25ee8edcb6R996

[cpevors]

This commit did restore the correct behaviour. cmangos/tbc-db@8d940e4

[insunaa]

The PR is still valid as it now also allows pre-2.4.0 behaviour if enabled. The appropriate flags still need to be investigated, as the flags applied by the DB change did include GO_FLAG_LOCKED for all objects involved, which we don't currently use in DB.