Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API safety checks, internal refactor and cleanup #15

Merged
merged 4 commits into from
Jun 6, 2024
Merged

API safety checks, internal refactor and cleanup #15

merged 4 commits into from
Jun 6, 2024

Conversation

nothingface0
Copy link
Contributor

  • Cleanup Dockerfile to have more layers for better caching
  • Added lots of unused files to .dockerignore
  • Basic type checking on API calls parameters (Thanks for the heads-up @gabrielmscampos)
  • Added API tests for possible incorrect API parameters
  • Cleanup for tests and fixtures
  • Bump version to 1.3.2

@nothingface0 nothingface0 merged commit b0d1692 into dev Jun 6, 2024
2 checks passed
@nothingface0 nothingface0 deleted the refactor_logging branch June 6, 2024 09:33
@gabrielmscampos
Copy link
Member

ευχαριστώ, τίποτα-πρόσωπο0!!!

nothingface0 added a commit that referenced this pull request Jun 6, 2024
@nothingface0
Squashed commit of the following:
202e0e0 
commit b0d1692
Merge: 9dabba0 68c23c9
Author: Dimitris Papagiannis <[email protected]>
Date:   Thu Jun 6 11:33:13 2024 +0200

    Merge pull request #15 from cms-DQM/refactor_logging

    API safety checks, internal refactor and cleanup

commit 68c23c9
Author: Dimitris Papagiannis <[email protected]>
Date:   Wed Jun 5 18:24:07 2024 +0200

    More layers for dockerfile for better caching, cleanup files in dockerignore,
    fix tests

commit 446dea3
Author: Dimitris Papagiannis <[email protected]>
Date:   Wed Jun 5 18:08:14 2024 +0200

    Added basic type checking in api arguments, updated tests

commit 19c2df8
Author: Dimitris Papagiannis <[email protected]>
Date:   Wed Jun 5 16:20:52 2024 +0200

    Update report, though it's unused

commit f4e8397
Author: Dimitris Papagiannis <[email protected]>
Date:   Wed Jun 5 16:19:44 2024 +0200

    Cleanup how database manager is instantiated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nothingface0 @gabrielmscampos