Restructure grabber.py
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup of logging as well, edit of a docstring.
- Split code into more functions to isolate functionality - Added more exception handling for cases that the cluster is unreachable.
nothingface0
force-pushed
the
handle_unavailable_machines
branch
from
ed67f75 to
5031947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, there was an idea to investigate whether, in the case that the playback BU machine is unreachable (the one that is used as a proxy for the other machines), cluster statuses for each host signifying they are "down" should be created or not. This is not necessarily a good idea, as it does not reflect reality: if the proxy machine is down, we cannot know whether the other machines are down or not. Only if the proxy machine is up, can we know for sure what the situation really is. For this reason, it was decided not to implement such a functionality.
The downside is that, if the proxy machine is down, we will not be getting any cluster status updates for any machine, meaning that the DB will only contain the last one available, which might be stale.