Fetch available CMSSW comparison reports from fff_dqmtools
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..and store them in the database. The latter is only storing the metadata of the comparisons (base, comp releases, PRs involved), and the actual HTML report is stored on the filesystem. Serve the HTML reports from a dedicated endpoint, separate API endpoints for querying the available ones.
nothingface0
force-pushed
the
fetch_comparison_results
branch
2 times, most recently
from
5e962ca to
1fed360
Compare
nothingface0
force-pushed
the
fetch_comparison_results
branch
4 times, most recently
from
53d2c23 to
db2d7d7
Compare
This is done on the backend (completely by hand, unfortunately), and handled by a dedicated js object handling the front-end part of the pagination. - API fixes page argument, if out of range. - comparison_id and page in URL control page behaviour. - Update css to override bootstrap colors
nothingface0
force-pushed
the
fetch_comparison_results
branch
from
7f2f150 to
c7f0e86
Compare
Having one huge endpoint for all was not easy to maintain
- API calls now split into individual methods - DB calls added and refactored for hostnames, statuses cmssw_prs, releases. - WIP on comparison reports. - Pagination wrapper for DB calls added (not thoroughly tested)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..and store them in the database. The latter
is only storing the metadata of the comparisons
(base, comp releases, PRs involved), and the
actual HTML report is stored on the filesystem.
Serve the HTML reports from a dedicated
endpoint, separate API endpoints for querying
the available ones.